linux-kernel - Re: [PATCH] Add space after ,

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55C77E13.8060300@lwfinger.net>
Date:	Sun, 9 Aug 2015 11:21:39 -0500
From:	Larry Finger <Larry.Finger@...inger.net>
To:	Swee Hua Law <sweehua81@...il.com>, Jes.Sorensen@...hat.com,
	gregkh@...uxfoundation.org
Cc:	aybuke.147@...il.com, linux-wireless@...r.kernel.org,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Add space after ,

On 08/09/2015 11:08 AM, Swee Hua Law wrote:
> add space after , to fix coding style issue
>
> Signed-off-by: Swee Hua Law <sweehua81@...il.com>
> ---
>   drivers/staging/rtl8723au/core/rtw_sreset.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723au/core/rtw_sreset.c b/drivers/staging/rtl8723au/core/rtw_sreset.c
> index 29a29d9..48b7723 100644
> --- a/drivers/staging/rtl8723au/core/rtw_sreset.c
> +++ b/drivers/staging/rtl8723au/core/rtw_sreset.c
> @@ -71,7 +71,7 @@ static void sreset_restore_security_station(struct rtw_adapter *padapter)
>   			/* pairwise key */
>   			rtw_setstakey_cmd23a(padapter, (unsigned char *)psta, true);
>   			/* group key */
> -			rtw_set_key23a(padapter,&padapter->securitypriv, padapter->securitypriv.dot118021XGrpKeyid, 0);
> +			rtw_set_key23a(padapter, &padapter->securitypriv, padapter->securitypriv.dot118021XGrpKeyid, 0);
>   		}
>   	}
>   }
>

There are at least three problems with this patch. The first is that your 
subject is really awful. You need to say that you are fixing a checkpatch 
warning, and then say exactly what is happening. The second probalm also 
concerns the subject, which needs to specify what component is being changed. 
For drivers in staging, the usual way to do this is to start the subject line 
with "staging: rtl8723au: ...". The third problem is that you should fix *ALL* 
the problems with a given line whenever you touch it. That line is clearly over 
the 80-character limit.

NACK

Larry

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/