linux-kernel - linux-4.2-rc6/drivers/extcon/extcon.c: 3 * bad tests ?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <DUB128-W141DC86E1C28C2DE0214539C710@phx.gbl>
Date:	Sun, 9 Aug 2015 21:30:24 +0000
From:	David Binderman <dcb314@...mail.com>
To:	"myungjoo.ham@...sung.com" <myungjoo.ham@...sung.com>,
	"cw00.choi@...sung.com" <cw00.choi@...sung.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: linux-4.2-rc6/drivers/extcon/extcon.c: 3 * bad tests ?

Hello there,

1.

[linux-4.2-rc6/drivers/extcon/extcon.c:153]: (style) Checking if unsigned variable 'id' is less than zero.

Source code is

    id = find_cable_id_by_name(edev, name);
    if (id < 0)

but

   unsigned int id;

Suggest sanity check return value from find_cable_id_by_name
*before* assigning it into an unsigned variable.

2.

[linux-4.2-rc6/drivers/extcon/extcon.c:384]: (style) Checking if unsigned variable 'id' is less than zero.

Duplicate.

3.

[linux-4.2-rc6/drivers/extcon/extcon.c:432]: (style) Checking if unsigned variable 'id' is less than zero.

Another duplicate.

Regards

David Binderman
 		 	   		  --
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/