linux-kernel - Re: [PATCH 2/2] perf evlist: Be more specific on -F/--freq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150809093425.GC17069@krava.brq.redhat.com>
Date:	Sun, 9 Aug 2015 11:34:25 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	LKML <linux-kernel@...r.kernel.org>,
	David Ahern <dsahern@...il.com>
Subject: Re: [PATCH 2/2] perf evlist: Be more specific on -F/--freq

On Sun, Aug 09, 2015 at 03:45:24PM +0900, Namhyung Kim wrote:
> Currently perf evlist -F shows the number as if it's always sampling
> frequency.  But we now support per-event freq/period settings.  So it'd
> better to show more detailed info whether it's freq or period.
> 
>   $ perf record -e 'cpu/config=1/,cpu/config=2,period=300000/' sleep 1
>   [ perf record: Woken up 1 times to write data ]
>   [ perf record: Captured and wrote 0.017 MB perf.data ]
> 
>   $ perf evlist -F
>   cpu/config=1/: sample_freq=4000
>   cpu/config=2,period=300000/: sample_period=300000
> 
> Signed-off-by: Namhyung Kim <namhyung@...nel.org>

Acked-by: Jiri Olsa <jolsa@...nel.org>

thanks,
jirka

> ---
>  tools/perf/util/evsel.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
> index f664a22b5fea..04fddddc6b6f 100644
> --- a/tools/perf/util/evsel.c
> +++ b/tools/perf/util/evsel.c
> @@ -2158,8 +2158,13 @@ int perf_evsel__fprintf(struct perf_evsel *evsel,
>  		printed += perf_event_attr__fprintf(fp, &evsel->attr,
>  						    __print_attr__fprintf, &first);
>  	} else if (details->freq) {
> -		printed += comma_fprintf(fp, &first, " sample_freq=%" PRIu64,
> -					 (u64)evsel->attr.sample_freq);
> +		const char *term = "sample_freq";
> +
> +		if (!evsel->attr.freq)
> +			term = "sample_period";
> +
> +		printed += comma_fprintf(fp, &first, " %s=%" PRIu64,
> +					 term, (u64)evsel->attr.sample_freq);
>  	}
>  out:
>  	fputc('\n', fp);
> -- 
> 2.5.0
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/