linux-kernel - Re: [PATCH v2 5/5] MIPS: ath79: Use the common clk API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55C745B7.3040002@hauke-m.de>
Date:	Sun, 09 Aug 2015 14:21:11 +0200
From:	Hauke Mehrtens <hauke@...ke-m.de>
To:	Alban Bedel <albeu@...e.fr>, linux-mips@...ux-mips.org,
	Ralf Baechle <ralf@...ux-mips.org>
CC:	Andrew Bresticker <abrestic@...omium.org>,
	Qais Yousef <qais.yousef@...tec.com>,
	Wolfram Sang <wsa@...-dreams.de>,
	Sergey Ryazanov <ryazanov.s.a@...il.com>,
	Gabor Juhos <juhosg@...nwrt.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 5/5] MIPS: ath79: Use the common clk API

On 04/19/2015 02:30 PM, Alban Bedel wrote:
> Make the code simpler and open the way for device tree clocks.
> 
> Signed-off-by: Alban Bedel <albeu@...e.fr>
> ---
>  arch/mips/Kconfig       |  1 +
>  arch/mips/ath79/clock.c | 29 ++---------------------------
>  2 files changed, 3 insertions(+), 27 deletions(-)
> 

I think this should be send at least to stable 4.1, because it fixes a
linking problem we are seeing in OpenWrt.

ath79 does not export clk_set_rate() and clk_round_rate(), but some
drivers are using it and they are not using the inline dummy method,
because CONFIG_HAVE_CLK is set for ath79.

ERROR: "clk_set_rate" [drivers/usb/phy/phy-generic.ko] undefined!
ERROR: "clk_round_rate" [drivers/media/v4l2-core/videodev.ko] undefined!
ERROR: "clk_set_rate" [drivers/media/v4l2-core/videodev.ko] undefined!

Hauke
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/