linux-kernel - Re: [PATCH v8 1/3] sysfs: added sysfs_link_entry_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 10 Aug 2015 11:40:28 +0300
From:	Jarkko Sakkinen <jarkko.sakkinen@...el.com>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>,
	peterhuewe@....de, tpmdd-devel@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org, NeilBrown <neilb@...e.de>,
	Vivien Didelot <vivien.didelot@...oirfairelinux.com>,
	Guenter Roeck <linux@...ck-us.net>
Subject: Re: [PATCH v8 1/3] sysfs: added sysfs_link_entry_to_kobj()

On Wed, Aug 05, 2015 at 01:11:23PM -0700, Greg Kroah-Hartman wrote:
> On Fri, Jul 03, 2015 at 05:27:18PM +0300, Jarkko Sakkinen wrote:
> > Added a new function sysfs_link_group_to_kobj() that adds a symlink
> > from attribute or group to a kobject. Exported kernfs_remove_by_name_ns
> > in order to provide a way to remove such symlinks.
> 
> This text doesn't match the function name you exported :(

D'oh.

> > 
> > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
> > ---
> >  fs/sysfs/group.c      | 44 ++++++++++++++++++++++++++++++++++++++++++++
> >  include/linux/sysfs.h | 10 ++++++++++
> >  2 files changed, 54 insertions(+)
> > 
> > diff --git a/fs/sysfs/group.c b/fs/sysfs/group.c
> > index b400c04..0fb4b6e 100644
> > --- a/fs/sysfs/group.c
> > +++ b/fs/sysfs/group.c
> > @@ -352,3 +352,47 @@ void sysfs_remove_link_from_group(struct kobject *kobj, const char *group_name,
> >  	}
> >  }
> >  EXPORT_SYMBOL_GPL(sysfs_remove_link_from_group);
> > +
> > +/**
> > + * __compat_sysfs_link_entry_to_kobj - add a symlink to a kobject pointing
> 
> Why __compat?

https://lkml.org/lkml/2015/7/2/455

Although, should have been '__compat_only'.

/Jarkko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/