linux-kernel - Re: [PATCH 1/3] nvmem: fix the out-of-range leak in read/write()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55C8658F.4000201@linaro.org>
Date:	Mon, 10 Aug 2015 09:49:19 +0100
From:	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:	Shunqian Zheng <zhengsq@...k-chips.com>,
	maxime.ripard@...e-electrons.com, heiko@...ech.de,
	linux-kernel@...r.kernel.org, caesar.wang@...k-chips.com
CC:	dianders@...omium.org, linux-rockchip@...ts.infradead.org,
	xjq@...k-chips.com
Subject: Re: [PATCH 1/3] nvmem: fix the out-of-range leak in read/write()



On 10/08/15 04:22, Shunqian Zheng wrote:
> From: ZhengShunQian <zhengsq@...k-chips.com>
>
> The position to read/write must be less than max
> register size.

>
> Signed-off-by: ZhengShunQian <zhengsq@...k-chips.com>
> ---
>   drivers/nvmem/core.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
> index d3c6676..f4af8e5 100644
> --- a/drivers/nvmem/core.c
> +++ b/drivers/nvmem/core.c
> @@ -67,7 +67,7 @@ static ssize_t bin_attr_nvmem_read(struct file *filp, struct kobject *kobj,
>   	int rc;
>
>   	/* Stop the user from reading */
> -	if (pos > nvmem->size)
> +	if (pos >= nvmem->size)
>   		return 0;
>
>   	if (pos + count > nvmem->size)
> @@ -92,7 +92,7 @@ static ssize_t bin_attr_nvmem_write(struct file *filp, struct kobject *kobj,
>   	int rc;
>
>   	/* Stop the user from writing */
> -	if (pos > nvmem->size)
> +	if (pos >= nvmem->size)
>   		return 0;
>
>   	if (pos + count > nvmem->size)
>

This looks good,

Acked-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/