linux-kernel - Re: [PATCH v2 4/8] drm: rockchip/dp: add rockchip platform dp driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150810100055.GB7850@ulmo.nvidia.com>
Date:	Mon, 10 Aug 2015 12:00:57 +0200
From:	Thierry Reding <treding@...dia.com>
To:	Yakir Yang <ykk@...k-chips.com>
CC:	Heiko Stübner <heiko@...ech.de>,
	Russell King <rmk+kernel@....linux.org.uk>,
	Fabio Estevam <fabio.estevam@...escale.com>,
	Jingoo Han <jingoohan1@...il.com>,
	Inki Dae <inki.dae@...sung.com>, <djkurtz@...gle.com>,
	<dianders@...gle.com>, <seanpaul@...gle.com>, <joe@...ches.com>,
	Takashi Iwai <tiwai@...e.de>,
	Andrzej Hajda <a.hajda@...sung.com>,
	Philipp Zabel <p.zabel@...gutronix.de>,
	David Airlie <airlied@...ux.ie>,
	Gustavo Padovan <gustavo.padovan@...labora.co.uk>,
	Seung-Woo Kim <sw0312.kim@...sung.com>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	Kukjin Kim <kgene@...nel.org>,
	Ajay Kumar <ajaykumar.rs@...sung.com>,
	Joonyoung Shim <jy0922.shim@...sung.com>,
	Vincent Palatin <vpalatin@...omium.org>,
	Mark Yao <mark.yao@...k-chips.com>,
	Andy Yan <andy.yan@...k-chips.com>, <ajaynumb@...il.com>,
	<dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>,
	<linux-samsung-soc@...r.kernel.org>,
	<linux-rockchip@...ts.infradead.org>, <linux-arm-ker@...L.NULL>,
	<nel@...ts.infradead.org>
Subject: Re: [PATCH v2 4/8] drm: rockchip/dp: add rockchip platform dp driver

On Sat, Aug 08, 2015 at 11:54:38AM +0800, Yakir Yang wrote:
[...]
>         edp: edp@...70000 {
[...]
>                 hsync-active-high = <0>;
>                 vsync-active-high = <0>;
>                 interlaced = <0>;

These look like they should come from the display mode definition (EDID)
rather than device tree.

>                 samsung,color-space = <0>;
>                 samsung,dynamic-range = <0>;
>                 samsung,ycbcr-coeff = <0>;

I think these should also come from EDID, though I'm not sure if we
store this in internal data structures yet.

>                 samsung,color-depth = <1>;

This is probably drm_display_info.bpc.

>                 samsung,link-rate = <0x0a>;
>                 samsung,lane-count = <1>;

And these should really be derived from values in the DPCD and adjusted
(if necessary) during link training.

Why would you ever want to hard-code the above?

> >>+	dp->clk_24m = devm_clk_get(dev, "clk_dp_24m");
> >Same here, maybe "dp_24m".
> Like my previous reply. And actually as those two clocks all have
> a common prefix "SCLK" in rk3288 clock tree, I thinkt we can name
> them to "sclk_dp" & "sclk_dp_24m", is it okay ?

I don't think there's a need for these common prefixes. The names here
are identifiers in the context of the IP block, so any SoC-specific
prefixes are irrelevant. Also they do appear, in DT and in code, in the
context of clocks already, so "sclk_" or "clk_" is completely redundant
in these names.

Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)