lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150810124947.GD1262@ulmo.nvidia.com>
Date:	Mon, 10 Aug 2015 14:49:48 +0200
From:	Thierry Reding <thierry.reding@...il.com>
To:	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc:	dri-devel@...ts.freedesktop.org, robdclark@...il.com,
	David Airlie <airlied@...ux.ie>, linux-kernel@...r.kernel.org,
	Rob Herring <robh+dt@...nel.org>, linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH RFC 4/5] drm/msm/hdmi: deprecate non standard clock-names

On Mon, Aug 10, 2015 at 12:59:49PM +0100, Srinivas Kandagatla wrote:
> This patch updates the bindings to discourage the usage of non standard
> clock names, this will help in projects focused on upstreaming.
> 
> These deprecated properties are still supported but will be remove over
> the time.
> 
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> ---
>  Documentation/devicetree/bindings/drm/msm/hdmi.txt | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/drm/msm/hdmi.txt b/Documentation/devicetree/bindings/drm/msm/hdmi.txt
> index 6dc202e..6fbfdd8 100644
> --- a/Documentation/devicetree/bindings/drm/msm/hdmi.txt
> +++ b/Documentation/devicetree/bindings/drm/msm/hdmi.txt
> @@ -12,16 +12,16 @@ Required properties:
>  - clocks: device clocks
>  - clock-names: Corresponding name for each entry in the clocks property.
>   for "qcom,hdmi-tx-8960" compatible names should be
> -	"core_clk"
> -	"master_iface_clk"
> -	"slave_iface_clk"
> +	"core_clk" is deprecated, use "core" instead
> +	"master_iface_clk" is deprecated, use "master_iface" instead
> +	"slave_iface_clk" is deprecated, use "slave_iface" instead
>  
>   for "qcom,hdmi-tx-8084" and "qcom,hdmi-tx-8074" compatible names should be
> -	"extp_clk"
> -	"alt_iface_clk"
> -	"iface_clk"
> -	"core_clk"
> -	"mdp_core_clk"
> +	"extp_clk" is deprecated, use "extp" instead
> +	"alt_iface_clk" is deprecated, use "alt_iface" intstead
> +	"iface_clk" is deprecated, use "iface" instead
> +	"core_clk" is deprecated, use "core" instead
> +	"mdp_core_clk" is deprecated, use "mdp_core" instead

Shouldn't there be a driver counterpart of this to accept the new names?
Otherwise people could be switching the DTS to the new value, but the
driver won't find the clocks it's looking for.

Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ