lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 11 Aug 2015 00:26:21 +0800 From: Yakir Yang <ykk@...k-chips.com> To: Russell King - ARM Linux <linux@....linux.org.uk>, linux-rockchip@...ts.infradead.org, alsa-devel@...a-project.org, dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org Cc: Fabio Estevam <fabio.estevam@...escale.com>, Takashi Iwai <tiwai@...e.de>, Sascha Hauer <s.hauer@...gutronix.de>, Jaroslav Kysela <perex@...ex.cz>, David Airlie <airlied@...ux.ie>, Mark Brown <broonie@...nel.org>, Philipp Zabel <p.zabel@...gutronix.de>, Andy Yan <andy.yan@...k-chips.com>, Jon Nettleton <jon.nettleton@...il.com> Subject: Re: [PATCH 9/9] drm: bridge/dw_hdmi-i2s-audio: add audio driver Hi Russell, 在 2015/8/10 23:48, Russell King - ARM Linux 写道: > On Sat, Aug 08, 2015 at 05:10:47PM +0100, Russell King wrote: >> From: Yakir Yang <ykk@...k-chips.com> >> >> Add ALSA based HDMI I2S audio driver for dw_hdmi. Sound card >> driver could connect to this codec through the codec dai name >> "dw-hdmi-i2s-audio". >> >> [Fixed IRQ name, MODULE_DESCRIPTION, MODULE_ALIAS in >> dw-hdmi-i2s-audio.c, and platform device name in dw-hdmi.c --rmk] >> >> Signed-off-by: Yakir Yang <ykk@...k-chips.com> >> Signed-off-by: Russell King <rmk+kernel@....linux.org.uk> > I'm dropping this patch after all as it no longer builds against modern > kernels due to the reference to the removed snd_soc_jack_new(). Its > replacement is at card level, and I don't think it's a simple case of > replacing it here. Hmm... I would rather to fix it in my side, and then I could rebase on your series, is it okay ? - Yakir >> +static int snd_dw_hdmi_audio_probe(struct snd_soc_codec *codec) >> +{ >> + struct snd_dw_hdmi *dw = snd_soc_codec_get_drvdata(codec); >> + int ret; >> + >> + ret = snd_soc_jack_new(codec, "dw Jack", SND_JACK_LINEOUT, >> + &dw->jack); > ... >> +static const struct snd_soc_codec_driver dw_hdmi_audio = { >> + .probe = snd_dw_hdmi_audio_probe, >> + .dapm_widgets = snd_dw_hdmi_audio_widgets, >> + .num_dapm_widgets = ARRAY_SIZE(snd_dw_hdmi_audio_widgets), >> + .dapm_routes = snd_dw_hdmi_audio_routes, >> + .num_dapm_routes = ARRAY_SIZE(snd_dw_hdmi_audio_routes), >> +}; >> + >> +static int dw_hdmi_audio_probe(struct platform_device *pdev) >> +{ >> + struct dw_hdmi_audio_data *data = pdev->dev.platform_data; >> + struct snd_dw_hdmi *dw; >> + int ret; >> + >> + dw = devm_kzalloc(&pdev->dev, sizeof(*dw), GFP_KERNEL); >> + if (!dw) >> + return -ENOMEM; >> + >> + dw->data = *data; >> + dw->dev = &pdev->dev; >> + dw->is_jack_ready = false; >> + platform_set_drvdata(pdev, dw); >> + >> + ret = request_irq(dw->data.irq, snd_dw_hdmi_irq, IRQF_SHARED, >> + DRIVER_NAME, dw); >> + if (ret) { >> + dev_err(&pdev->dev, "request irq failed (%d)\n", ret); >> + return -EINVAL; >> + } >> + >> + ret = snd_soc_register_codec(&pdev->dev, &dw_hdmi_audio, >> + &dw_hdmi_audio_dai, 1); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists