linux-kernel - Re: [PATCH v2] openvswitch: Fix L4 checksum handling when dealing with IP fragments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150810.112328.309806698983159152.davem@davemloft.net>
Date:	Mon, 10 Aug 2015 11:23:28 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	ggriffin.kernel@...il.com
Cc:	pshelar@...ira.com, netdev@...r.kernel.org, dev@...nvswitch.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] openvswitch: Fix L4 checksum handling when dealing
 with IP fragments

From: Glenn Griffin <ggriffin.kernel@...il.com>
Date: Mon, 10 Aug 2015 10:43:16 -0700

> On Mon, Aug 03, 2015 at 02:03:28PM -0700, David Miller wrote:
>> From: Glenn Griffin <ggriffin.kernel@...il.com>
>> Date: Mon, 3 Aug 2015 09:56:54 -0700
>> 
>> > openvswitch modifies the L4 checksum of a packet when modifying
>> > the ip address. When an IP packet is fragmented only the first
>> > fragment contains an L4 header and checksum. Prior to this change
>> > openvswitch would modify all fragments, modifying application data
>> > in non-first fragments, causing checksum failures in the
>> > reassembled packet.
>> > 
>> > Signed-off-by: Glenn Griffin <ggriffin.kernel@...il.com>
>> > ---
>> > Changes in v2:
>> >   - Compare frag_off in network byte order rather than host byte order
>> 
>> Applied and queued up for -stable.
> 
> I noticed this change didn't seem to make it into 4.2-rc6. I'm not too
> familiar with the release schedule so wasn't sure if that was expected
> or an oversight. Will this remain queued up until the 4.3 merge window
> opens?

It's in my 'net' tree and will be pushed to Linus's tree at a time that I
deem appropriate.  Usually I try to push to Linus one every week or so,
in order for changes to soak and get tested in my tree before they get
pushed to his.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/