linux-kernel - Re: [PATCH] staging: wilc100: Remove pointer and integer comparision

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150810183856.GM5180@mwanda>
Date:	Mon, 10 Aug 2015 21:38:56 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Chandra Gorentla <csgorentla@...il.com>
Cc:	rachel.kim@...el.com, dean.lee@...el.com, chris.park@...el.com,
	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	linux-wireless@...r.kernel.org, johnny.kim@...el.com,
	linux-kernel@...r.kernel.org, sudipm.mukherjee@...il.com
Subject: Re: [PATCH] staging: wilc100: Remove pointer and integer comparision

Warnings are not a bad thing they are a valuable marker to let us know
which code is broken.  If we just silence the warning in the laziest
possible way then we are throwing away valuable information.  It's
better to leave the warning there so that the next person can fix it
properly.

If you want to leave the code as-is that is absolutely fine with me, but
don't remove the warning until someone can look at this a bit carefully.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/