linux-kernel - Re: [PATCH 2/3] kobject: export kset_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 10 Aug 2015 15:04:42 -0400
From:	"Gabriel L. Somlo" <somlo@....edu>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	ralf@...ux-mips.org, zajec5@...il.com, paul@...an.com,
	galak@...eaurora.org, linux-api@...r.kernel.org,
	linux-kernel@...r.kernel.org, matt.fleming@...el.com,
	x86@...nel.org, linux-efi@...r.kernel.org, qemu-devel@...gnu.org,
	lersek@...hat.com, jordan.l.justen@...el.com,
	gleb@...udius-systems.com, pbonzini@...hat.com, kraxel@...hat.com,
	eblake@...hat.com, rjones@...hat.com,
	kernelnewbies@...nelnewbies.org
Subject: Re: [PATCH 2/3] kobject: export kset_find_obj() to be used from
 modules

On Mon, Aug 10, 2015 at 11:54:00AM -0700, Greg KH wrote:
> On Mon, Aug 10, 2015 at 02:43:10PM -0400, Gabriel L. Somlo wrote:
> > On Mon, Aug 10, 2015 at 11:33:04AM -0700, Greg KH wrote:
> > > On Mon, Aug 10, 2015 at 12:31:19PM -0400, Gabriel L. Somlo wrote:
> > > > From: "Gabriel Somlo" <somlo@....edu>
> > > > 
> > > > Signed-off-by: Gabriel Somlo <somlo@....edu>
> > > > ---
> > > >  lib/kobject.c | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > > 
> > > > diff --git a/lib/kobject.c b/lib/kobject.c
> > > > index 3e3a5c3..f9754a0 100644
> > > > --- a/lib/kobject.c
> > > > +++ b/lib/kobject.c
> > > > @@ -1058,3 +1058,4 @@ EXPORT_SYMBOL(kobject_del);
> > > >  
> > > >  EXPORT_SYMBOL(kset_register);
> > > >  EXPORT_SYMBOL(kset_unregister);
> > > > +EXPORT_SYMBOL(kset_find_obj);
> > > 
> > > checkpatch doesn't like this for obvious reasons :)
> > 
> > When I run checkpatch on this one, it comes back fine. Could you
> > please elaborate ?
> > 
> > [staging]$ scripts/checkpatch.pl
> > 0002-kobject-export-kset_find_obj-to-be-used-from-modules.patch 
> > total: 0 errors, 0 warnings, 4 lines checked
> > 
> > 0002-kobject-export-kset_find_obj-to-be-used-from-modules.patch has no
> > obvious style problems and is ready for submission.
> 
> EXPORT_SYMBOL() should be below the function definition itself, not at
> the bottom of the file.  Odd that checkpatch doesn't catch this when
> done in this manner, it will if you run it on the whole file after your
> patch is applied (along with the existing problems.)

Got it, fix lined up for v2

> But this is a minor issue, see my other review first...

Yeah, but it was the low hanging fruit, so I replied to it first ;)

Thanks much,
--Gabriel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/