linux-kernel - Re: [v2 2/3] serial: 8250_dw: dw8250_setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 10 Aug 2015 19:13:39 +0000
From:	Noam Camus <noamc@...hip.com>
To:	Greg KH <greg@...ah.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>
Subject: Re: [v2 2/3] serial: 8250_dw: dw8250_setup_port() use endianness
 aware read.

From: Greg KH <greg@...ah.com>
Sent: Tuesday, August 4, 2015 2:42 AM

> > -     reg = readl(p->membase + DW_UART_CPR);
> > +     reg = (p->iotype == UPIO_MEM32BE) ?
> > +             ioread32be(p->membase + DW_UART_CPR) :
> > +             readl(p->membase + DW_UART_CPR);
>
> Same here.
>
> And shouldn't all of this be "hidden" behind something else?  You should
not have to do this for each readl call...
>

As I wrote for last patch, I will add another level for accessors and use it here.

Noam--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/