linux-kernel - Re: [PATCH v2 net-next] bpf: s390: Fix build error caused by the struct bpf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55C9B131.50108@iogearbox.net>
Date:	Tue, 11 Aug 2015 10:24:17 +0200
From:	Daniel Borkmann <daniel@...earbox.net>
To:	Kaixu Xia <xiakaixu@...wei.com>, fengguang.wu@...el.com,
	davem@...emloft.net, ast@...mgrid.com, schwidefsky@...ibm.com,
	heiko.carstens@...ibm.com
CC:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	wangnan0@...wei.com, Michael Holzheu <holzheu@...ux.vnet.ibm.com>
Subject: Re: [PATCH v2 net-next] bpf: s390: Fix build error caused by the
 struct bpf_array member name changed

On 08/11/2015 08:53 AM, Kaixu Xia wrote:
> There is a build error that "'struct bpf_array' has no member
> named 'prog'" on s390. In commit 2a36f0b, the member 'prog' of
> struct bpf_array is replaced by 'ptrs'. So this patch fixes it.
>
> Signed-off-by: Kaixu Xia <xiakaixu@...wei.com>

You were also asked to add a proper Fixes tag :

Fixes: 2a36f0b92eb6 ("bpf: Make the bpf_prog_array_map more generic")

I guess this bug was reported by Fengguang as you have him in Cc ?

If that should be the case, then please also add a "Reported-by:" tag
for his bug report.

Code looks good to me.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/