linux-kernel - Re: [Patch v2] align crash_notes allocation to make it be inside one physical page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150811084212.GD9748@dhcp-17-102.nay.redhat.com>
Date:	Tue, 11 Aug 2015 16:42:12 +0800
From:	Baoquan He <bhe@...hat.com>
To:	Minfei Huang <mhuang@...hat.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>, ebiederm@...ssion.com,
	vgoyal@...hat.com, dyoung@...hat.com, lisa.mitchell@...com,
	tatsu@...jp.nec.com, seiji.aguchi.tr@...achi.com,
	linux-kernel@...r.kernel.org, kexec@...ts.infradead.org
Subject: Re: [Patch v2] align crash_notes allocation to make it be inside one
 physical page

Hi,

On 08/11/15 at 04:01pm, Minfei Huang wrote:
> Baoquan.
> 
> If the size of notes never be exceeded to PAGE_SIZE, I think we can
> revert below patch, since the situation which describes in patch does
> not happen.
> 
>     commit 38dfac843cb6d7be1874888839817404a15a6b3c
>     Author: Greg Pearson <greg.pearson@...com>
>     Date:   Mon Feb 10 14:25:36 2014 -0800
>     
>         vmcore: prevent PT_NOTE p_memsz overflow during header update
> 
> What do you think about this?

Yeah, I am fine with this reverting. If people all agree with this I can
post patch to revert this. In fact I am eagerer to revert below commit
since it's  a littble bit confusing after crash_notes crossing 2
pages bug is fixed. Below commit is a work around fix , but it's too much. 
I am willing to hear people's idea.

commit 34b47764297130b21aaeb4cc6119bb811814b8e3
Author: WANG Chao <chaowang@...hat.com>
Date:   Tue Feb 17 13:46:01 2015 -0800

    vmcore: fix PT_NOTE n_namesz, n_descsz overflow issue

Thanks
Baoquan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/