linux-kernel - Re: [PATCH] sched/numa: Fix NUMA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 10 Aug 2015 21:06:57 -0400
From:	Rik van Riel <riel@...hat.com>
To:	Aravind Gopalakrishnan <Aravind.Gopalakrishnan@....com>,
	mingo@...hat.com, peterz@...radead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sched/numa: Fix NUMA_DIRECT topology identification

On 08/10/2015 09:20 PM, Aravind Gopalakrishnan wrote:
> Systems which have all nodes at a distance of at most
> 1 hop should be identified as 'NUMA_DIRECT'.
> 
> However, the scheduler incorrectly identifies it as
> 'NUMA_BACKPLANE'. This is because 'n' is assigned to
> sched_max_numa_distance but the code (mis)interprets it
> to mean 'number of hops'.
> 
> Rik had actually used sched_domains_numa_levels for detecting
> a 'NUMA_DIRECT' topology-
> http://marc.info/?l=linux-kernel&m=141279712429834&w=2
> 
> But that was changed when he removed the hops table in the
> subsequent version-
> http://marc.info/?l=linux-kernel&m=141353106106771&w=2

Good catch! Thank you!

> Fixing the issue here.
> 
> Signed-off-by: Aravind Gopalakrishnan <Aravind.Gopalakrishnan@....com>

Reviewed-by: Rik van Riel <riel@...hat.com>

-- 
All rights reversed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/