| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1439288024-13359-3-git-send-email-zhengsq@rock-chips.com> Date: Tue, 11 Aug 2015 18:13:41 +0800 From: Shunqian Zheng <zhengsq@...k-chips.com> To: gregkh@...uxfoundation.org, srinivas.kandagatla@...aro.org, maxime.ripard@...e-electrons.com, heiko@...ech.de, caesar.wang@...k-chips.com Cc: mturquette@...libre.com, sboyd@...eaurora.org, linux-clk@...r.kernel.org, dianders@...omium.org, linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org, xjq@...k-chips.com, ZhengShunQian <zhengsq@...k-chips.com> Subject: [PATCH v2 2/5] nvmem: fix the out-of-range leak in read/write() From: ZhengShunQian <zhengsq@...k-chips.com> The position to read/write must be less than max register size. Signed-off-by: ZhengShunQian <zhengsq@...k-chips.com> Acked-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org> --- drivers/nvmem/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index d3c6676..f4af8e5 100644 --- a/drivers/nvmem/core.c +++ b/drivers/nvmem/core.c @@ -67,7 +67,7 @@ static ssize_t bin_attr_nvmem_read(struct file *filp, struct kobject *kobj, int rc; /* Stop the user from reading */ - if (pos > nvmem->size) + if (pos >= nvmem->size) return 0; if (pos + count > nvmem->size) @@ -92,7 +92,7 @@ static ssize_t bin_attr_nvmem_write(struct file *filp, struct kobject *kobj, int rc; /* Stop the user from writing */ - if (pos > nvmem->size) + if (pos >= nvmem->size) return 0; if (pos + count > nvmem->size) -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists