linux-kernel - RE: [PATCH 1/1] mm: compaction: include compact

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <040301d0d423$0f1b36d0$2d51a470$@samsung.com>
Date:	Tue, 11 Aug 2015 16:15:54 +0530
From:	PINTU KUMAR <pintu.k@...sung.com>
To:	'Vlastimil Babka' <vbabka@...e.cz>, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	iamjoonsoo.kim@....com, mhocko@...e.cz, riel@...hat.com,
	emunson@...mai.com, mgorman@...e.de, zhangyanfei@...fujitsu.com,
	rientjes@...gle.com
Cc:	cpgs@...sung.com, pintu_agarwal@...oo.com, pintu.k@...look.com,
	vishnu.ps@...sung.com, rohit.kr@...sung.com
Subject: RE: [PATCH 1/1] mm: compaction: include compact_nodes in compaction.h

Hi,

> -----Original Message-----
> From: Vlastimil Babka [mailto:vbabka@...e.cz]
> Sent: Friday, August 07, 2015 7:48 PM
> To: Pintu Kumar; akpm@...ux-foundation.org; linux-kernel@...r.kernel.org;
> linux-mm@...ck.org; iamjoonsoo.kim@....com; mhocko@...e.cz;
> riel@...hat.com; emunson@...mai.com; mgorman@...e.de;
> zhangyanfei@...fujitsu.com; rientjes@...gle.com
> Cc: cpgs@...sung.com; pintu_agarwal@...oo.com; pintu.k@...look.com;
> vishnu.ps@...sung.com; rohit.kr@...sung.com
> Subject: Re: [PATCH 1/1] mm: compaction: include compact_nodes in
> compaction.h
> 
> On 08/07/2015 04:03 PM, Pintu Kumar wrote:
> > This patch declares compact_nodes prototype in compaction.h header
> > file.
> > This will allow us to call compaction from other places.
> > For example, during system suspend, suppose we want to check the
> > fragmentation state of the system. Then based on certain threshold, we
> > can invoke compaction, when system is idle.
> > There could be other use cases.
> 
> Isn't it more common to introduce such visibility changes only as part of series
> that actually benefit from it?
> 
Other series are not ready right now and not defined yet. It may take longer time.
I thought, it is left to the user, if somebody wants to invoke compaction from other sub-system.

> Otherwise next month somebody might notice that it's unused outside
> compaction.c and send a cleanup patch to make it static again...
> 
> > Signed-off-by: Pintu Kumar <pintu.k@...sung.com>
> > ---
> >   include/linux/compaction.h |    2 +-
> >   mm/compaction.c            |    2 +-
> >   2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/include/linux/compaction.h b/include/linux/compaction.h
> > index aa8f61c..800ff50 100644
> > --- a/include/linux/compaction.h
> > +++ b/include/linux/compaction.h
> > @@ -50,7 +50,7 @@ extern bool compaction_deferred(struct zone *zone, int
> order);
> >   extern void compaction_defer_reset(struct zone *zone, int order,
> >   				bool alloc_success);
> >   extern bool compaction_restarting(struct zone *zone, int order);
> > -
> > +extern void compact_nodes(void);
> >   #else
> >   static inline unsigned long try_to_compact_pages(gfp_t gfp_mask,
> >   			unsigned int order, int alloc_flags, diff --git
> a/mm/compaction.c
> > b/mm/compaction.c index 16e1b57..b793922 100644
> > --- a/mm/compaction.c
> > +++ b/mm/compaction.c
> > @@ -1657,7 +1657,7 @@ static void compact_node(int nid)
> >   }
> >
> >   /* Compact all nodes in the system */ -static void
> > compact_nodes(void)
> > +void compact_nodes(void)
> >   {
> >   	int nid;
> >
> >

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/