linux-kernel - Re: [PATCH] bq2415x_charger: Allow to load and use driver even if notify device is not registered yet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150811112343.GA1461@pali>
Date:	Tue, 11 Aug 2015 13:23:43 +0200
From:	Pali Rohár <pali.rohar@...il.com>
To:	Sebastian Reichel <sre@...nel.org>,
	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
	David Woodhouse <dwmw2@...radead.org>
Cc:	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bq2415x_charger: Allow to load and use driver even if
 notify device is not registered yet

On Wednesday 05 August 2015 15:26:52 Pali Rohár wrote:
> On Saturday 25 July 2015 23:46:56 Pali Rohár wrote:
> > -	if (psy != bq->notify_psy)
> > -		return NOTIFY_OK;
> > +	/* Ignore event if it was not send by notify_node/notify_device */
> > +	if (bq->notify_node) {
> > +		if (psy->dev.parent &&
> > +		    psy->dev.parent->of_node != bq->notify_node)
> > +			return NOTIFY_OK;
> 
> There is missing branch for case when psy->dev.parent is NULL. Logical
> error... I will send new version of patch.
> 
> Correct logic should be: ignore psy dev which sent event if it is not
> notify dev specified in board/DT config of bq2415x psy dev.
> 

Fixed in v2.

-- 
Pali Rohár
pali.rohar@...il.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/