linux-kernel - Re: [PATCH] PM / domains: Align column headers and data in pm_genpd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 11 Aug 2015 08:29:48 -0700
From:	Kevin Hilman <khilman@...nel.org>
To:	Geert Uytterhoeven <geert+renesas@...der.be>
Cc:	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Ulf Hansson <ulf.hansson@...aro.org>,
	Maciej Matraszek <m.matraszek@...sung.com>,
	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PM / domains: Align column headers and data in pm_genpd_summary output

Geert Uytterhoeven <geert+renesas@...der.be> writes:

> "domain": header is indented by 4, data by 0 spaces => 0 spaces
> "/device": header is indented by 11, data by 4 spaces => 4 spaces
> "slaves": header is indented by 47, data by 49 spaces => 48 spaces
>
> Ruler:
>     1234567890123456789012345678901234567890123456789012345678901234567890
>
> Before:
>
> 	domain                      status         slaves
> 	       /device                                      runtime status
>     ----------------------------------------------------------------------
>     a3sp                            on               a2us
> 	/devices/platform/e60b0000.i2c                      suspended
>
> After:
>
>     domain                          status          slaves
> 	/device                                             runtime status
>     ----------------------------------------------------------------------
>     a3sp                            on              a2us
> 	/devices/platform/e60b0000.i2c                      suspended
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>

Acked-by: Kevin Hilman <khilman@...aro.org>

> ---
>  drivers/base/power/domain.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
> index c9bc913a938c31e0..a0a99d55022f5387 100644
> --- a/drivers/base/power/domain.c
> +++ b/drivers/base/power/domain.c
> @@ -2082,7 +2082,7 @@ static int pm_genpd_summary_one(struct seq_file *s,
>  
>  	if (WARN_ON(genpd->status >= ARRAY_SIZE(status_lookup)))
>  		goto exit;
> -	seq_printf(s, "%-30s  %-15s  ", genpd->name, status_lookup[genpd->status]);
> +	seq_printf(s, "%-30s  %-15s ", genpd->name, status_lookup[genpd->status]);
>  
>  	/*
>  	 * Modifications on the list require holding locks on both
> @@ -2117,8 +2117,8 @@ static int pm_genpd_summary_show(struct seq_file *s, void *data)
>  	struct generic_pm_domain *genpd;
>  	int ret = 0;
>  
> -	seq_puts(s, "    domain                      status         slaves\n");
> -	seq_puts(s, "           /device                                      runtime status\n");
> +	seq_puts(s, "domain                          status          slaves\n");
> +	seq_puts(s, "    /device                                             runtime status\n");
>  	seq_puts(s, "----------------------------------------------------------------------\n");
>  
>  	ret = mutex_lock_interruptible(&gpd_list_lock);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/