linux-kernel - Re: [PATCH 9/15 V2] drivers: rtc: Drop (un)likely before IS_ERR(_OR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150811155434.GT3411@piout.net>
Date:	Tue, 11 Aug 2015 17:54:34 +0200
From:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:	Viresh Kumar <viresh.kumar@...aro.org>
Cc:	akpm@...ux-foundation.org, linaro-kernel@...ts.linaro.org,
	linux-kernel@...r.kernel.org,
	"moderated list:BLACKFIN RTC DRIVER" 
	<adi-buildroot-devel@...ts.sourceforge.net>,
	Alessandro Zummo <a.zummo@...ertech.it>,
	Hans Ulli Kroll <ulli.kroll@...glemail.com>,
	"moderated list:ARM/CORTINA SYSTEMS GEMINI ARM ARCHITECTURE" 
	<linux-arm-kernel@...ts.infradead.org>,
	"open list:REAL TIME CLOCK (RTC) SUBSYSTEM" 
	<rtc-linux@...glegroups.com>
Subject: Re: [PATCH 9/15 V2] drivers: rtc: Drop (un)likely before
 IS_ERR(_OR_NULL)

On 31/07/2015 at 16:23:43 +0530, Viresh Kumar wrote :
> IS_ERR(_OR_NULL) already contain an 'unlikely' compiler flag and there
> is no need to do that again from its callers. Drop it.
> 
> gemini driver was using likely() for a failure case while the rtc driver
> is getting registered. That looks wrong and it should really be
> unlikely. But because we are killing all the unlikely() flags, lets kill
> that too.
> 
> Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>
> ---
> V1->V2:
> - Removed the likely() part from gemini driver and the changelog wasn't
>   updated to match that. Fixed the changelog now.
> 
>  drivers/rtc/interface.c  | 2 +-
>  drivers/rtc/rtc-bfin.c   | 2 +-
>  drivers/rtc/rtc-gemini.c | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 

Applied, thanks.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/