linux-kernel - Re: [Patch v3] driver/i2c/mux: Add register-based mux i2c-mux-reg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150811161610.GA1523@katana>
Date:	Tue, 11 Aug 2015 18:16:10 +0200
From:	Wolfram Sang <wsa@...-dreams.de>
To:	York Sun <yorksun@...escale.com>
Cc:	linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org,
	Paul Bolle <pebolle@...cali.nl>,
	Peter Korsgaard <peter.korsgaard@...co.com>,
	Alexander Sverdlin <alexander.sverdlin@...ia.com>
Subject: Re: [Patch v3] driver/i2c/mux: Add register-based mux i2c-mux-reg

> >> +	if (of_find_property(np, "little-endian", NULL)) {
> > 
> > You should check for a "big-endian" property as well, no?
> 
> I use the little-endian as an option to indicate the nature of litten-endian
> register. It is default to big-endian if this property doesn't exist. I prefer
> this way unless you strongly suggest to add both and throw out an error if
> neither exists.

I'd think that "little-endian" or "big-endian" force a setting. If none
is present, we shall take the CPU endianess. Or am I overlooking
something?

Oh, and I forgot the biggest issue: I get build errors, because
__LITTLE_ENDIAN__ should be __LITTLE_ENDIAN. Is this a recent change or
why did it work for you?

Thanks for the quick response,

   Wolfram


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)