linux-kernel - Re: [PATCH V2 1/6] PM / OPP: Free resources and properly return error on failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150811171132.GA25166@mwanda>
Date:	Tue, 11 Aug 2015 20:11:32 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Viresh Kumar <viresh.kumar@...aro.org>
Cc:	Rafael Wysocki <rjw@...ysocki.net>, nm@...com,
	sboyd@...eaurora.org, linaro-kernel@...ts.linaro.org,
	linux-pm@...r.kernel.org, khilman@...aro.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Len Brown <len.brown@...el.com>,
	open list <linux-kernel@...r.kernel.org>,
	Pavel Machek <pavel@....cz>
Subject: Re: [PATCH V2 1/6] PM / OPP: Free resources and properly return
 error on failure

On Tue, Aug 11, 2015 at 08:29:38PM +0530, Viresh Kumar wrote:
> > This is weird to me, because we are going backwards.  What happens if
> > we goto free_table without adding anything?
> 
> It will WARN() today.

Then the current code is buggy.

> 
> > I suspect it's fine, but if
> > it's a bug then this code still has problems.
> 
> I don't think we have a bug here, we never added anything and so don't
> need to free it.
> 
> > What about if we only increment count when _opp_add_static_v2()
> > succeeds
> 
> That's not what we want.

If the first call to _opp_add_static_v2() fails we call
of_free_opp_table() and you say that triggers a WARN().

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/