linux-kernel - Re: [PATCH] surface pro 3: Add support driver for Surface Pro 3 buttons

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 10 Aug 2015 19:56:51 -0700
From:	Darren Hart <dvhart@...radead.org>
To:	Joe Perches <joe@...ches.com>
Cc:	"Chen, Yu C" <yu.c.chen@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Zhang, Rui" <rui.zhang@...el.com>,
	"jslaby@...e.com" <jslaby@...e.com>,
	"platform-driver-x86@...r.kernel.org" 
	<platform-driver-x86@...r.kernel.org>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"Wysocki, Rafael J" <rafael.j.wysocki@...el.com>,
	"Westerberg, Mika" <mika.westerberg@...el.com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"mchehab@....samsung.com" <mchehab@....samsung.com>,
	"arnd@...db.de" <arnd@...db.de>
Subject: Re: [PATCH] surface pro 3: Add support driver for Surface Pro 3
 buttons

On Thu, Aug 06, 2015 at 11:55:29AM -0700, Joe Perches wrote:
> On Wed, 2015-08-05 at 16:47 -0700, Darren Hart wrote:
> > On Thu, Aug 06, 2015 at 11:20:44AM +0000, Chen, Yu C wrote:
> []
> > > Is it ok to keep these codes and add comments like:
> 
> It's your code Yu, do whatever you think appropriate.
> 
> > > /*
> > >  * When a button(power button/volume button/home button) is 
> > >  * pressed down or released, different ACPI notification codes 
> > >  * will be generated. We can distinguish different event code 
> > >  * and value of buttons by these notification codes, then pass
> > >  * (EV_KEY, event code(key_code), value(pressed)) to input layer.
> > >  */
> > 
> > The commentary is useful regardless. However, I suspect Joe was
> > referring to the approach pairing the PRESS and RELEASE cases?
> > 
> 
> True.
> 
> btw Darren, your computer's email time setting seems off.

Nothing gets past kernel devs! Corporate firewall broke ntp for Linux VM from
where I sent this, didn't notice until too late.

-- 
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/