linux-kernel - Re: [PATCH 3.2 090/110] NET: AX.25: Stop heartbeat timer on disconnect.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1439324020.10857.61.camel@decadent.org.uk>
Date:	Tue, 11 Aug 2015 22:13:40 +0200
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Richard Stearn <richard@...-stearn.demon.co.uk>
Cc:	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	akpm@...ux-foundation.org, Ralf Baechle <ralf@...ux-mips.org>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH 3.2 090/110] NET: AX.25: Stop heartbeat timer on
 disconnect.

On Mon, 2015-08-10 at 12:52 +0100, Richard Stearn wrote:
> Ben Hutchings wrote:
> > 3.2.71-rc1 review patch.  If anyone has any objections, please let me know.
> > 
> > ------------------
> > 
> > From: Richard Stearn <richard@...-stearn.demon.co.uk>
> > 
> > commit da278622bf04f8ddb14519a2b8214e108ef26101 upstream.
> > 
> > This may result in a kernel panic.  The bug has always existed but
> > somehow we've run out of luck now and it bites.
> > 
> > Signed-off-by: Richard Stearn <richard@...-stearn.demon.co.uk>
> > Signed-off-by: Ralf Baechle <ralf@...ux-mips.org>
> > Signed-off-by: David S. Miller <davem@...emloft.net>
> > Signed-off-by: Ben Hutchings <ben@...adent.org.uk>
> > ---
> >  net/ax25/ax25_subr.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > --- a/net/ax25/ax25_subr.c
> > +++ b/net/ax25/ax25_subr.c
> > @@ -265,6 +265,7 @@ void ax25_disconnect(ax25_cb *ax25, int
> >  {
> >  > > 	> > ax25_clear_queues(ax25);
> >  
> > +> > 	> > ax25_stop_heartbeat(ax25);
> >  > > 	> > ax25_stop_t1timer(ax25);
> >  > > 	> > ax25_stop_t2timer(ax25);
> >  > > 	> > ax25_stop_t3timer(ax25);
> 
> This patch should _not_ be applied.
> Breaks other parts of the driver.
> Investigations on-going.

OK, I'll drop it for now.

Ben.

-- 
Ben Hutchings
Theory and practice are closer in theory than in practice.
                                - John Levine, moderator of comp.compilers


Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)