linux-kernel - Re: [PATCH] Bluetooth: hci_bcm: improve use of gpios API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150812181905.78ade990@canb.auug.org.au>
Date:	Wed, 12 Aug 2015 18:19:05 +1000
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
Cc:	Linus Walleij <linus.walleij@...aro.org>,
	Gustavo Padovan <gustavo@...ovan.org>,
	Frederic Danis <frederic.danis@...ux.intel.com>,
	Marcel Holtmann <marcel@...tmann.org>,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-bluetooth@...r.kernel.org, kernel@...gutronix.de
Subject: Re: [PATCH] Bluetooth: hci_bcm: improve use of gpios API

Hi Uwe,

On Wed, 12 Aug 2015 09:20:56 +0200 Uwe Kleine-König <u.kleine-koenig@...gutronix.de> wrote:
>
> devm_gpiod_get currently has an optional parameter to set initial
> direction and value for the requested gpio. Make use of this to simplify
> the driver and make it not fail to build when this parameter is made
> mandatory (which is scheduled for 4.3-rc1).
> 
> Moreover use the _optional variant of devm_gpiod_get to simplify error
> handling (which also gets more strict for free).
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> ---
> Hello,
> 
> this is needed on top of commit 0395ffc1ee05 ("Bluetooth: hci_bcm: Add
> PM for BCM devices") incombination with b17d1bf16cc7 ("gpio: make flags
> mandatory for gpiod_get functions") which is currently sitting in next.
> 
> Stephen fixed it up with a simpler patch, which works fine, but doesn't
> benefit from the nice things devm_gpiod_get et al offer.
> 
> Best regards
> Uwe
> 
>  drivers/bluetooth/hci_bcm.c | 24 +++++++++---------------
>  1 file changed, 9 insertions(+), 15 deletions(-)

I will use this instead of my simple patch tomorrow if the bluetooth
maintainer has not applied it.

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/