lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <1439373065-11020-1-git-send-email-maxime.lorrillere@gmail.com>
Date:	Wed, 12 Aug 2015 11:51:04 +0200
From:	Maxime Lorrillere <maxime.lorrillere@...il.com>
To:	Oleg Drokin <oleg.drokin@...el.com>,
	Andreas Dilger <andreas.dilger@...el.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	linux-kernel@...r.kernel.org,
	Maxime Lorrillere <maxime.lorrillere@...il.com>
Subject: [PATCH 1/2] staging: lustre: fix static declarations in libcfs

This patch fix the following sparse warnings in libcfs/linux/linux-debug.c:
>>> linux-debug.c:64:6: warning: symbol 'lnet_upcall' was not declared. Should it be static?
>>> linux-debug.c:65:6: warning: symbol 'lnet_debug_log_upcall' was not declared. Should it be static?

Signed-off-by: Maxime Lorrillere <maxime.lorrillere@...il.com>
---
 drivers/staging/lustre/lustre/libcfs/linux/linux-debug.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/lustre/lustre/libcfs/linux/linux-debug.c b/drivers/staging/lustre/lustre/libcfs/linux/linux-debug.c
index 4545d54..f0331fa 100644
--- a/drivers/staging/lustre/lustre/libcfs/linux/linux-debug.c
+++ b/drivers/staging/lustre/lustre/libcfs/linux/linux-debug.c
@@ -61,8 +61,9 @@
 
 #include <linux/kallsyms.h>
 
-char lnet_upcall[1024] = "/usr/lib/lustre/lnet_upcall";
-char lnet_debug_log_upcall[1024] = "/usr/lib/lustre/lnet_debug_log_upcall";
+static char lnet_upcall[1024] = "/usr/lib/lustre/lnet_upcall";
+static char lnet_debug_log_upcall[1024] =
+	"/usr/lib/lustre/lnet_debug_log_upcall";
 
 /**
  * Upcall function once a Lustre log has been dumped.
-- 
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ