linux-kernel - Re: [PATCH] x86/mce: fix failed to reenable cmci when swiching to interrupt mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55CAAA9F.70303@huawei.com>
Date:	Wed, 12 Aug 2015 10:08:31 +0800
From:	Xie XiuQi <xiexiuqi@...wei.com>
To:	"Luck, Tony" <tony.luck@...el.com>, Borislav Petkov <bp@...en8.de>
CC:	"tglx@...utronix.de" <tglx@...utronix.de>,
	"mingo@...hat.com" <mingo@...hat.com>,
	"hpa@...or.com" <hpa@...or.com>, "x86@...nel.org" <x86@...nel.org>,
	"linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"zhangliguang@...wei.com" <zhangliguang@...wei.com>
Subject: Re: [PATCH] x86/mce: fix failed to reenable cmci when swiching to
 interrupt mode

On 2015/8/12 2:52, Luck, Tony wrote:
>> Well, ok, but do it differently, please: rename
>> cmci_storm_disable_banks() to cmci_storm_switch_banks(bool on) which
>> turns them on and off. Unless Tony has a better suggestion...
>
> I like the boolean argument ... but not the "switch_banks" name. It sounds more
> like we are juggling between banks, rather than setting a switch/flag in a bank.
>
> How does "cmci_storm_set_cmci(bool on)" sound?  Too many "cmci" in one name?

Thanks, I'll use this name.

--
Xie XiuQi

>
> -Tony
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/