linux-kernel - Re: [PATCH] Staging: media/bcm2048: Fix line over 80 characters warning as detected by checkpatch.pl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150812111935.GA15037@pali>
Date:	Wed, 12 Aug 2015 13:19:36 +0200
From:	Pali Rohár <pali.rohar@...il.com>
To:	"Shah, Yash (Y.)" <yshah1@...teon.com>
Cc:	"mchehab@....samsung.com" <mchehab@....samsung.com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"hans.verkuil@...co.com" <hans.verkuil@...co.com>,
	"prabhakar.csengg@...il.com" <prabhakar.csengg@...il.com>,
	"hamohammed.sa@...il.com" <hamohammed.sa@...il.com>,
	"luis@...ethencourt.com" <luis@...ethencourt.com>,
	"wsa@...-dreams.de" <wsa@...-dreams.de>,
	"elfring@...rs.sourceforge.net" <elfring@...rs.sourceforge.net>,
	"carlos@...rcia.org" <carlos@...rcia.org>,
	"vthakkar1994@...il.com" <vthakkar1994@...il.com>,
	"linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Babu, Viswanathan (V.)" <vbabu3@...teon.com>
Subject: Re: [PATCH] Staging: media/bcm2048: Fix line over 80 characters
 warning as  detected by checkpatch.pl

On Wednesday 12 August 2015 11:12:49 Shah, Yash (Y.) wrote:
> From: Yash Shah <yshah1@...teon.com>
> 
> Fix line over 80 characters warning as detected by checkpatch.pl
> 
> Signed-off-by: Yash Shah <yshah1@...teon.com>
> ---
>  drivers/staging/media/bcm2048/radio-bcm2048.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
> index 8bc68e2..d36350e 100644
> --- a/drivers/staging/media/bcm2048/radio-bcm2048.c
> +++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
> @@ -2243,7 +2243,8 @@ static ssize_t bcm2048_fops_read(struct file *file, char __user *buf,
>  
>  		tmpbuf[i] = bdev->rds_info.radio_text[bdev->rd_index+i+2];
>  		tmpbuf[i+1] = bdev->rds_info.radio_text[bdev->rd_index+i+1];
> -		tmpbuf[i+2] = (bdev->rds_info.radio_text[bdev->rd_index + i] & 0xf0) >> 4;
> +		tmpbuf[i+2] = (bdev->rds_info.radio_text[bdev->rd_index + i]
> +				 & 0xf0) >> 4;
>  		if ((bdev->rds_info.radio_text[bdev->rd_index+i] &
>  			BCM2048_RDS_CRC_MASK) == BCM2048_RDS_CRC_UNRECOVARABLE)
>  			tmpbuf[i+2] |= 0x80;

Hi! I think that code after this change is less readable as before.

-- 
Pali Rohár
pali.rohar@...il.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/