linux-kernel - Re: [PATCH] kvm:x86:Fix error handling in the function ioapic_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <55CB3FF6.3000407@redhat.com>
Date:	Wed, 12 Aug 2015 14:45:42 +0200
From:	Paolo Bonzini <pbonzini@...hat.com>
To:	Nicholas Krause <xerofoify@...il.com>, gleb@...nel.org
Cc:	x86@...nel.org, kvm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kvm:x86:Fix error handling in the function
 ioapic_write_indirect



On 11/08/2015 19:39, Nicholas Krause wrote:
> This fixes error handling in the function ioapic_write_indirect to
> properly check if the call to the function ioapoc_service service
> has failed by not returning the value zero to indicate success to
> check if this occurs when calling this particular function and if
> so return immediately to the caller of ioapic_write_indirect due
> to us no longer being able to continue the function
> ioapic_write_indirect after this call fails.

This is not true.

You are back to the older problem that you are not trying to understand
the functions you are modifying.


Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/