linux-kernel - Re: [PATCH] Make alignment cflags configurable.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1439383844.3100.81.camel@infradead.org>
Date:	Wed, 12 Aug 2015 13:50:44 +0100
From:	David Woodhouse <dwmw2@...radead.org>
To:	dl9pf@....de
Cc:	tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
	x86@...nel.org, linux-kernel@...r.kernel.org,
	llvmlinux@...ts.linuxfoundation.org, behanw@...verseincode.com
Subject: Re: [PATCH] Make alignment cflags configurable.

On Wed, 2015-08-12 at 14:32 +0200, dl9pf@....de wrote:
> From: Jan-Simon Möller <dl9pf@....de>
> 
> This patch adds switches for
> -falign-jumps=1
> and
> -falign-loops=1
> 
> Default is off by intention to allow seamless operation.
> 
> Signed-off-by: Jan-Simon Möller <dl9pf@....de>

You could mention that this is to fix the clang build. But why is it
needed? It isn't that clang just doesn't accept the option, is it?
Otherwise we could just use $(call cc-option, -falign-jumps=1) etc.

Did you get to the bottom of the clang failure here? Just turning this
off without a coherent explanation doesn't seem like the right thing to
do.

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse@...el.com                              Intel Corporation

Download attachment "smime.p7s" of type "application/x-pkcs7-signature" (5691 bytes)