linux-kernel - Re: Problem with error paths in various functions calling kvm_io_bus_unregister

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <55CB460F.2000305@redhat.com>
Date:	Wed, 12 Aug 2015 15:11:43 +0200
From:	Paolo Bonzini <pbonzini@...hat.com>
To:	nick <xerofoify@...il.com>, gleb@...nel.org
Cc:	kvm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: Problem with error paths in various functions calling
 kvm_io_bus_unregister_dev



On 11/08/2015 16:02, nick wrote:
> Our we to just assume
> that calls to kvm_io_bug_unregister_dev always succeed as I disagree due to
> it allocating memory in kernel space that can easily fail. In additon I
> was wondering how the maintainers would like me to handle these calls as
> it's difficult due to it already being in error paths. Further more below
> is a link to the files and how the calls to kvm_io_bus_register_dev are 
> executed in the respective error paths.
> http://lxr.free-electrons.com/ident?i=kvm_io_bus_unregister_dev

You're right; the fix is not simple.  The best way is to introduce a new
API to register or unregister multiple devices atomically.  This gets
rid of calls in the error paths.


Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/