linux-kernel - Re: [PATCH] staging: media:lirc: Added a newline character after declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 12 Aug 2015 08:49:30 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Aparna Karuthodi <kdasaparna@...il.com>
Cc:	devel@...verdev.osuosl.org, mchehab@....samsung.com,
	jarod@...sonet.com, linux-kernel@...r.kernel.org,
	linux-media@...r.kernel.org
Subject: Re: [PATCH] staging: media:lirc: Added a newline character after
 declaration

On Wed, Aug 12, 2015 at 08:41:42PM +0530, Aparna Karuthodi wrote:
> Added a newline character to remove a coding style warning detected
> by checkpatch.
> 
> The warning is given below:
> drivers/staging/media/lirc/lirc_serial.c:1169: WARNING: quoted string split
> across lines
> 
> Signed-off-by: Aparna Karuthodi <kdasaparna@...il.com>
> ---
>  drivers/staging/media/lirc/lirc_serial.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/media/lirc/lirc_serial.c b/drivers/staging/media/lirc/lirc_serial.c
> index 19628d0..628577f 100644
> --- a/drivers/staging/media/lirc/lirc_serial.c
> +++ b/drivers/staging/media/lirc/lirc_serial.c
> @@ -1165,7 +1165,7 @@ module_init(lirc_serial_init_module);
>  module_exit(lirc_serial_exit_module);
>  
>  MODULE_DESCRIPTION("Infra-red receiver driver for serial ports.");
> -MODULE_AUTHOR("Ralph Metzler, Trent Piepho, Ben Pfaff, "
> +MODULE_AUTHOR("Ralph Metzler, Trent Piepho, Ben Pfaff,\n"
>  	      "Christoph Bartelmus, Andrei Tanas");

No, you just changed the way this string looks, that's not ok at all.

This is fine the way it is, you can ignore it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/