linux-kernel - Re: [PATCH] pinctrl-zynq.c: Fix typos in smc0_nand_grp and smc0_nor_grp

Open Source and information security mailing list archives

Message-ID: <CAAtXAHdbHoqMQP0wHpHiUbD6d6W8WcDaB=5VR2D5Nh29Seue9A@mail.gmail.com>
Date:	Wed, 12 Aug 2015 09:27:40 -0700
From:	Moritz Fischer <moritz.fischer@...us.com>
To:	Mike Looijmans <mike.looijmans@...ic.nl>
Cc:	linux-gpio@...r.kernel.org,
	Linus Walleij <linus.walleij@...aro.org>,
	linux-kernel@...r.kernel.org,
	Michal Simek <michal.simek@...inx.com>,
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
	Sören Brinkmann <soren.brinkmann@...inx.com>
Subject: Re: [PATCH] pinctrl-zynq.c: Fix typos in smc0_nand_grp and smc0_nor_grp

Acked-by: Moritz Fischer <moritz.fischer@...us.com>

On Wed, Aug 12, 2015 at 7:22 AM, Mike Looijmans <mike.looijmans@...ic.nl> wrote:
> Group names should be smc0_nand_grp and smc0_nor_grp, otherwise you'll
> get errors like this if you try to pinmux them via the devicetree:
> zynq-pinctrl 700.pinctrl: invalid group "smc0_nand_grp" for function "smc0_nand"
>
> Probably a typo while creating these tables.
>
> Signed-off-by: Mike Looijmans <mike.looijmans@...ic.nl>
> Acked-by: Sören Brinkmann <soren.brinkmann@...inx.com>
> ---
>  drivers/pinctrl/pinctrl-zynq.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-zynq.c b/drivers/pinctrl/pinctrl-zynq.c
> index 7ce23b6..5aafea8 100644
> --- a/drivers/pinctrl/pinctrl-zynq.c
> +++ b/drivers/pinctrl/pinctrl-zynq.c
> @@ -706,10 +706,10 @@ static const char * const sdio1_wp_groups[] = {"gpio0_0_grp",
>                 "gpio0_39_grp", "gpio0_41_grp", "gpio0_43_grp",
>                 "gpio0_45_grp", "gpio0_47_grp", "gpio0_49_grp",
>                 "gpio0_51_grp", "gpio0_53_grp", "sdio1_emio_wp_grp"};
> -static const char * const smc0_nor_groups[] = {"smc0_nor"};
> +static const char * const smc0_nor_groups[] = {"smc0_nor_grp"};
>  static const char * const smc0_nor_cs1_groups[] = {"smc0_nor_cs1_grp"};
>  static const char * const smc0_nor_addr25_groups[] = {"smc0_nor_addr25_grp"};
> -static const char * const smc0_nand_groups[] = {"smc0_nand"};
> +static const char * const smc0_nand_groups[] = {"smc0_nand_grp"};
>  static const char * const can0_groups[] = {"can0_0_grp", "can0_1_grp",
>                 "can0_2_grp", "can0_3_grp", "can0_4_grp", "can0_5_grp",
>                 "can0_6_grp", "can0_7_grp", "can0_8_grp", "can0_9_grp",
> --
> 1.9.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives