linux-kernel - Re: [PATCH v4] iio: adc: xilinx-xadc: Push interrupts into hardirq context

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55CB7558.3090608@linutronix.de>
Date:	Wed, 12 Aug 2015 18:33:28 +0200
From:	Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To:	Lars-Peter Clausen <lars@...afoo.de>,
	Xander Huff <xander.huff@...com>, jic23@...nel.org
CC:	knaack.h@....de, pmeerw@...erw.net, michal.simek@...inx.com,
	soren.brinkmann@...inx.com, linux-iio@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-rt-users@...r.kernel.org, linux-kernel@...r.kernel.org,
	joe.hershberger@...com, joshc@...com, nathan.sullivan@...com,
	jaeden.amero@...com
Subject: Re: [PATCH v4] iio: adc: xilinx-xadc: Push interrupts into hardirq
 context

On 08/12/2015 05:17 PM, Lars-Peter Clausen wrote:
> On 08/12/2015 01:00 AM, Xander Huff wrote:
>> Unfortunately, this breaks PREEMPT_RT builds, where a spinlock can sleep,
>> and is thus not able to be acquired from a hardirq handler. This patch gets
>> rid of the threaded handler and pushes all interrupt handling into the
>> hardirq context, and uses request_irq().
>>
>> To validate that this change has no impact on RT performance, here are
>> cyclictest values with no processes running:
> 
> Looks good, thanks.
> 
> Acked-by: Lars-Peter Clausen <lars@...afoo.de>

Yes, I'm fine with the rework, too.

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/