linux-kernel - Re: [PATCH] extcon: palmas: Fix build break due to devm_gpiod_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 13 Aug 2015 10:06:57 +0300
From:	Roger Quadros <rogerq@...com>
To:	Chanwoo Choi <cw00.choi@...sung.com>,
	<linux-kernel@...r.kernel.org>
CC:	<sfr@...b.auug.org.au>, <u.kleine-koenig@...gutronix.de>,
	<jim.epost@...il.com>
Subject: Re: [PATCH] extcon: palmas: Fix build break due to devm_gpiod_get_optional
 API change

Hi Chanwoo,

On 13/08/15 03:29, Chanwoo Choi wrote:
> Commit b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions")
> changes the prototype of devm_gpiod_get_optional() API which should include
> the falgs mandatory.

s/falgs/flags

> 
> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> Signed-off-by: Chanwoo Choi <cw00.choi@...sung.com>
> ---
>  drivers/extcon/extcon-palmas.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c
> index 662e91778cb0..308928d44ead 100644
> --- a/drivers/extcon/extcon-palmas.c
> +++ b/drivers/extcon/extcon-palmas.c
> @@ -208,7 +208,8 @@ static int palmas_usb_probe(struct platform_device *pdev)
>  			palmas_usb->wakeup = pdata->wakeup;
>  	}
>  
> -	palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id");
> +	palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id",
> +							GPIOD_IN);
>  	if (IS_ERR(palmas_usb->id_gpiod)) {
>  		dev_err(&pdev->dev, "failed to get id gpio\n");
>  		return PTR_ERR(palmas_usb->id_gpiod);
> 

Can you please include the following headers in this patch?

#include <linux/gpio.h>
#include <linux/gpio/consumer.h>

This should fix the randconfig build errors reported by Jim Davis at
http://article.gmane.org/gmane.linux.kernel/2018960

cheers,
-roger
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/