linux-kernel - Re: [PATCH v2] extcon: palmas: Fix build break due to devm_gpiod_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150813084042.GC9999@pengutronix.de>
Date:	Thu, 13 Aug 2015 10:40:42 +0200
From:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
To:	Chanwoo Choi <cw00.choi@...sung.com>
Cc:	linux-kernel@...r.kernel.org, sfr@...b.auug.org.au, rogerq@...com
Subject: Re: [PATCH v2] extcon: palmas: Fix build break due to
 devm_gpiod_get_optional API change

On Thu, Aug 13, 2015 at 05:17:05PM +0900, Chanwoo Choi wrote:
> "With commit b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions")
s/"//

> it becomes necessary to pass the flags argument. And this patch add the gpio
s/add/adds/

> header file to fix the build break when use random configuration file.
s/break/breakage/; s/use/build testing with/; s/file/files/

(That's at least what my German mind tells ...)

> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> Signed-off-by: Chanwoo Choi <cw00.choi@...sung.com>
> ---
>  drivers/extcon/extcon-palmas.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c
> index 662e91778cb0..93c30a885740 100644
> --- a/drivers/extcon/extcon-palmas.c
> +++ b/drivers/extcon/extcon-palmas.c
> @@ -29,6 +29,7 @@
>  #include <linux/of.h>
>  #include <linux/of_platform.h>
>  #include <linux/of_gpio.h>
> +#include <linux/gpio/consumer.h>
>  #include <linux/workqueue.h>
>  
>  #define USB_GPIO_DEBOUNCE_MS	20	/* ms */
> @@ -208,7 +209,8 @@ static int palmas_usb_probe(struct platform_device *pdev)
>  			palmas_usb->wakeup = pdata->wakeup;
>  	}
>  
> -	palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id");
> +	palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id",
> +							GPIOD_IN);
This isn't aligned with the opening parenthesis in the line above. But
IIRC this isn't a hard requirement, so *shrug*.

Acked-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/