linux-kernel - Re: [REPOST PATCH] kexec: Remove the unnecessary conditional judgement to simplify the code logic

Open Source and information security mailing list archives

Message-ID: <20150813005525.GB7852@verge.net.au>
Date:	Thu, 13 Aug 2015 09:55:25 +0900
From:	Simon Horman <horms@...ge.net.au>
To:	Minfei Huang <mnfhuang@...il.com>, akpm@...ux-foundation.org
Cc:	vgoyal@...hat.com, ebiederm@...ssion.com,
	kexec@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [REPOST PATCH] kexec: Remove the unnecessary conditional
 judgement to simplify the code logic

On Tue, Jul 28, 2015 at 12:46:42PM +0800, Minfei Huang wrote:
> Transforming PFN(Page Frame Number) to struct page is never failure, so
> we can simplify the code logic to do the image->control_page assignment
> directly in the loop, and remove the unnecessary conditional judgement.
> 
> Signed-off-by: Minfei Huang <mnfhuang@...il.com>
> Acked-by: Dave Young <dyoung@...hat.com>
> Acked-by: Vivek Goyal <vgoyal@...hat.com>

Andrew, could you consider picking this up.
It seems to have been sufficiently reviewed, acked, etc...

> ---
>  kernel/kexec.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/kernel/kexec.c b/kernel/kexec.c
> index 6f1ed75..cf82474 100644
> --- a/kernel/kexec.c
> +++ b/kernel/kexec.c
> @@ -807,11 +807,10 @@ static struct page *kimage_alloc_crash_control_pages(struct kimage *image,
>  		/* If I don't overlap any segments I have found my hole! */
>  		if (i == image->nr_segments) {
>  			pages = pfn_to_page(hole_start >> PAGE_SHIFT);
> +			image->control_page = hole_end;
>  			break;
>  		}
>  	}
> -	if (pages)
> -		image->control_page = hole_end;
>  
>  	return pages;
>  }
> -- 
> 2.4.0
> 
> 
> _______________________________________________
> kexec mailing list
> kexec@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives