lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 13 Aug 2015 12:04:29 +0100 From: Sudeep Holla <sudeep.holla@....com> To: Grygorii Strashko <grygorii.strashko@...com>, Marc Zyngier <Marc.Zyngier@....com> CC: Sudeep Holla <sudeep.holla@....com>, "tglx@...utronix.de" <tglx@...utronix.de>, "tony@...mide.com" <tony@...mide.com>, "linux@....linux.org.uk" <linux@....linux.org.uk>, "jason@...edaemon.net" <jason@...edaemon.net>, "nsekhar@...com" <nsekhar@...com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "balbi@...com" <balbi@...com>, "linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org> Subject: Re: [PATCH v2 6/6] irqchip: crossbar: fix irq masking at suspend On 13/08/15 11:17, Grygorii Strashko wrote: > On 08/13/2015 12:30 PM, Sudeep Holla wrote: >> >> >> On 12/08/15 18:46, Grygorii Strashko wrote: >>> All ARM GIC IRQs have to masked during suspend if they are not >>> wakeup source. Now this is not happen, since switching to >>> use IRQ domain hierarchy, because suspend_device_irq() only checks flags >>> in the last IRQ chip in hierarchy for IRQCHIP_MASK_ON_SUSPEND >>> bit set. And in the case of TI OMAP DRA7 the last IRQ chip is TI Crossbar >>> which do not have this flag set. >>> >>> In case of TI OMAP DRA7 the following IRQ hierarchy is defined: >>> ARM GIC <- OMAP wakeupgen <- TI CBAR >>> ARM GIC - IRQCHIP_MASK_ON_SUSPEND=n >> >> May be this won't affect your platform or this patch but even GIC marks >> IRQCHIP_MASK_ON_SUSPEND=y now since GIC doesn't provide any facility to >> configure the wakeup source and keeps all the interrupt source enabled. > > That's true for next, bur not true for 4.2-rc6 or 4.1 :( > True, I just wanted to ensure there is no assumption. [...] >> >> Also the beginning of the commit message contradicts when you also say >> in the following statement IRQCHIP_MASK_ON_SUSPEND=n. So you may need to >> update the log. > > I'll try to reword. What I've tried to mention that IRQs masking on > suspend is default expected behavior and that how it was before > switching to IRQ domain hierarchy. > > "All ARM GIC IRQs have to masked during suspend if they are not > wakeup source - this is expected behavior and that's how it was before > switching to IRQ domain hierarchy. ..." > ok? > My mistake I referred the code after it was converted to use stack domains. So I missed to understand that you were using gic_arch_extn flags before to override GIC flags as gic_set_irqchip_flags was not used when I removed it. Sorry for the noise, you can retain the commit log as is. Regards, Sudeep -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists