linux-kernel - Re: [PATCH 15/15] hmm/dummy: dummy driver for testing and showcasing the HMM API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1508131016070.9016@lenovo>
Date:	Thu, 13 Aug 2015 15:45:40 +0200
From:	Sylvain Jeaugey <sjeaugey@...dia.com>
To:	Jérôme Glisse <jglisse@...hat.com>
CC:	<akpm@...ux-foundation.org>, <linux-kernel@...r.kernel.org>,
	<linux-mm@...ck.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	<joro@...tes.org>, Mel Gorman <mgorman@...e.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Andrea Arcangeli <aarcange@...hat.com>,
	Johannes Weiner <jweiner@...hat.com>,
	Larry Woodman <lwoodman@...hat.com>,
	Rik van Riel <riel@...hat.com>,
	Dave Airlie <airlied@...hat.com>,
	Brendan Conoboy <blc@...hat.com>,
	Joe Donohue <jdonohue@...hat.com>,
	Christophe Harle <charle@...dia.com>,
	Duncan Poole <dpoole@...dia.com>,
	Sherry Cheung <SCheung@...dia.com>,
	Subhash Gutti <sgutti@...dia.com>,
	John Hubbard <jhubbard@...dia.com>,
	Mark Hairgrove <mhairgrove@...dia.com>,
	Lucien Dunning <ldunning@...dia.com>,
	"Cameron Buschardt" <cabuschardt@...dia.com>,
	Arvind Gopalakrishnan <arvindg@...dia.com>,
	Haggai Eran <haggaie@...lanox.com>,
	Shachar Raindel <raindel@...lanox.com>,
	Liran Liss <liranl@...lanox.com>,
	Roland Dreier <roland@...estorage.com>,
	Ben Sander <ben.sander@....com>,
	Greg Stoner <Greg.Stoner@....com>,
	John Bridgman <John.Bridgman@....com>,
	Michael Mantor <Michael.Mantor@....com>,
	Paul Blinzer <Paul.Blinzer@....com>,
	Leonid Shamis <Leonid.Shamis@....com>,
	Laurent Morichetti <Laurent.Morichetti@....com>,
	Alexander Deucher <Alexander.Deucher@....com>,
	Linda Wang <lwang@...hat.com>, Kevin E Martin <kem@...hat.com>,
	Jeff Law <law@...hat.com>, Or Gerlitz <ogerlitz@...lanox.com>,
	Sagi Grimberg <sagig@...lanox.com>
Subject: Re: [PATCH 15/15] hmm/dummy: dummy driver for testing and showcasing
 the HMM API

Hi Jerome,

I get a compilation error when building the hmm_dummy module (undefined 
function hmm_pte_test_select).

On Fri, 17 Jul 2015, Jérôme Glisse wrote:
> +static int dummy_mirror_pt_populate(struct hmm_mirror *mirror,
> +                                 struct hmm_event *event)
> [ snip ]
> +             if (!mpte || !hmm_pte_test_valid_pfn(mpte) ||
> +                 !hmm_pte_test_select(mpte)) {
>From what I understand, the select flag no longer exists in HMM PTE, 
hence hmm_pte_test_select is missing.
Removing this sanity check, the module compiles and loads correctly.

Aside from that problem, is there a userspace test available which 
interfaces with the dummy module ?

Thanks,
Sylvain