linux-kernel - Re: [PATCH v2] Input: drivers/joystick: use parallel port device model

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 14 Aug 2015 12:25:42 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>, pali.rohar@...il.com
Cc:	linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
	gregkh@...uxfoundation.org
Subject: Re: [PATCH v2] Input: drivers/joystick: use parallel port device
 model

On Thu, Aug 13, 2015 at 09:26:02AM -0700, Dmitry Torokhov wrote:
> On Thu, Aug 13, 2015 at 07:16:14PM +0530, Sudip Mukherjee wrote:
> > On Sat, Aug 08, 2015 at 04:05:15PM +0530, Sudip Mukherjee wrote:
> > > On Tue, Aug 04, 2015 at 07:55:51PM +0530, Sudip Mukherjee wrote:
> > > > Modify db9 driver to use the new Parallel Port device model.
> > > > 
> > > > Signed-off-by: Sudip Mukherjee <sudip@...torindia.org>
> > > > ---
> > > > 
> > > > v2: an extra check was removed. db9_base could not be removed. Already
> > > > mailed you the reasons, reference is at:
> > > > https://lkml.org/lkml/2015/8/3/403
> > > 
> > > Hi Dmitry,
> > > I was telling you on the other thread that to remove db9_base we will
> > > need to modify the parport code and then it has to be tested by everyone
> > > again and that will also change the old behaviour of parport. The v2 to
> > > which I am replying now is still having that db9_base.
> > > 
> > > Please see the following patch, this is the minimum change required to
> > > update db9 driver. Personally I donot like this approach as in this
> > > method if a parallel port is hotplugged after this driver is loaded then
> > > it will not work. Please let me know your views on the posted v2 and
> > > also on the following proposal.
> > 
> > Hi Dmitry,
> > Did you have a chance to look at this?
> 
> Right, so I agree that we should allow for hotplug and so the v2 is in
> that sense is better than v3.
> 
> I still would prefer for the core to keep track of relationship between
> devices and drivers, but if you would prefer to postpone implementing it
> that woudl be fine.
Thanks. Right now the code is already a mixture of the new code and the
old code and its almost a mess. After all drivers are converted and the
old code removed then the parport code will become much simpler than
what it is now. And it will be easy to make those enhancements at that
time.
> 
> > Pali Rohár has the hardware and he is ready to test it.
> 
> Pali, could you give the v2 version of the patch a spin
> (https://patchwork.kernel.org/patch/6940321/)?
Adding Pali to the cc list.

Hi Pali,
Are you still away from your desktop with the joystick? or can it be
tested?

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/