lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <20150814081617.GA4158@arch.fritz.box>
Date:	Fri, 14 Aug 2015 10:16:17 +0200
From:	Andrey Shvetsov <andrey.shvetsov.ml@...il.com>
To:	Tomas Melin <tomas.melin@....fi>
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging/most: fix return value for DIM_GetChannelState

On Sun, Aug 09, 2015 at 05:08:41PM +0300, Tomas Melin wrote:
> Return NULL instead of 0 for invalid input.
> 
> Signed-off-by: Tomas Melin <tomas.melin@....fi>
Signed-off-by: Andrey Shvetsov <andrey.shvetsov@....de>
> ---
>  drivers/staging/most/hdm-dim2/dim2_hal.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/most/hdm-dim2/dim2_hal.c b/drivers/staging/most/hdm-dim2/dim2_hal.c
> index 01b7489..a54cf2c 100644
> --- a/drivers/staging/most/hdm-dim2/dim2_hal.c
> +++ b/drivers/staging/most/hdm-dim2/dim2_hal.c
> @@ -889,7 +889,7 @@ struct dim_ch_state_t *DIM_GetChannelState(struct dim_channel *ch,
>  		struct dim_ch_state_t *state_ptr)
>  {
>  	if (!ch || !state_ptr)
> -		return 0;
> +		return NULL;
>  
>  	state_ptr->ready = ch->state.level < 2;
>  	state_ptr->done_buffers = ch->done_sw_buffers_number;
> -- 
> 1.9.1
> 
> _______________________________________________
> devel mailing list
> devel@...uxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ