linux-kernel - [PATCH 3/7] selftests: exec: fix for running and installing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 14 Aug 2015 21:43:34 +0800
From:	Bamvor Jian Zhang <bamvor.zhangjian@...aro.org>
To:	linux-kernel@...r.kernel.org
Cc:	broonie@...aro.org, khilman@...aro.org, tyler.baker@...aro.org,
	bamvor.zhangjian@...aro.org, shuahkh@....samsung.com
Subject: [PATCH 3/7] selftests: exec: fix for running and installing

Fix three issues in exec testcase:

Add RUN_TESTS rules in order to running the testcases in the build
directory through "make TARGETS=exec kselftest"

Copy symbol link and non-executable file instead of install it,
otherwise this test will fail after installation.

Exec testcases need a "Makefile" in line 346, otherwise it will
be ENOENT instead of EACCES.

Signed-off-by: Bamvor Jian Zhang <bamvor.zhangjian@...aro.org>
---
 tools/testing/selftests/exec/Makefile | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/tools/testing/selftests/exec/Makefile b/tools/testing/selftests/exec/Makefile
index 6b76bfd..34966a0 100644
--- a/tools/testing/selftests/exec/Makefile
+++ b/tools/testing/selftests/exec/Makefile
@@ -1,4 +1,4 @@
-CFLAGS = -Wall
+CFLAGS = -Wall -g
 BINARIES = execveat
 DEPS = execveat.symlink execveat.denatured script
 all: $(BINARIES) $(DEPS)
@@ -18,11 +18,19 @@ execveat.denatured: execveat
 	$(CC) $(CFLAGS) -o $@ $^
 
 TEST_PROGS := execveat
-TEST_FILES := $(DEPS)
+TEST_FILES := script
 
 include ../lib.mk
 
-override EMIT_TESTS := echo "mkdir -p subdir; (./execveat && echo \"selftests: execveat [PASS]\") || echo \"selftests: execveat [FAIL]\""
+override RUN_TESTS := mkdir -p subdir; (./execveat && echo "selftests: execveat [PASS]") || echo "selftests: execveat [FAIL]"
+
+override EMIT_TESTS := echo "mkdir -p subdir; touch Makefile; (./execveat && echo \"selftests: execveat [PASS]\") || echo \"selftests: execveat [FAIL]\""
+
+override define INSTALL_RULE
+       mkdir -p $(INSTALL_PATH)
+       install -t $(INSTALL_PATH) $(TEST_PROGS) $(TEST_PROGS_EXTENDED) $(TEST_FILES)
+       cp -a execveat.symlink execveat.denatured $(INSTALL_PATH)
+endef
 
 clean:
 	rm -rf $(BINARIES) $(DEPS) subdir.moved execveat.moved xxxxx*
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/