linux-kernel - Re: [PATCH v2] staging: lustre: fix symbol redeclared with different type in libcfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <138C4E5D-DD96-488D-97B0-CC44006DABBF@intel.com>
Date:	Sat, 15 Aug 2015 10:13:53 +0000
From:	"Drokin, Oleg" <oleg.drokin@...el.com>
To:	Maxime Lorrillere <maxime.lorrillere@...il.com>
CC:	"Dilger, Andreas" <andreas.dilger@...el.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"<linux-kernel@...r.kernel.org>" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] staging: lustre: fix symbol redeclared with
 different type in libcfs


On Aug 15, 2015, at 4:35 AM, Maxime Lorrillere wrote:

> lbug_with_loc is declared with __attribute__((noreturn)) in libcfs_private.h
> and without this attribute in linux-debug.c. This generates the following
> sparse error:
>>>> drivers/staging/lustre/lustre/libcfs/linux/linux-debug.c:149:6: error: symbol 'lbug_with_loc' redeclared with different type (originally declared at drivers/staging/lustre/lustre/libcfs/linux/../../../include/linux/libcfs/libcfs_private.h:82) - different modifiers
> 
> This patches removes this attribute in libcfs_private.h as it seems to me that
> this optimization is not necessary.

Well, the whole idea is that the attribute tells the compiler and thing like static analysis tools
that there's no return from this function.
This helps us to highlight dead code and also certain false positive warnings
abut stuff possibly used not-initialized and the like.
I'd rather prefer the actual function to be declared as no-return.

Thanks.
> 
> Signed-off-by: Maxime Lorrillere <maxime.lorrillere@...il.com>
> ---
> drivers/staging/lustre/include/linux/libcfs/libcfs_private.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/lustre/include/linux/libcfs/libcfs_private.h b/drivers/staging/lustre/include/linux/libcfs/libcfs_private.h
> index 9544860..e60b92b 100644
> --- a/drivers/staging/lustre/include/linux/libcfs/libcfs_private.h
> +++ b/drivers/staging/lustre/include/linux/libcfs/libcfs_private.h
> @@ -79,7 +79,7 @@ do {									\
> 
> #define KLASSERT(e) LASSERT(e)
> 
> -void lbug_with_loc(struct libcfs_debug_msg_data *)__attribute__((noreturn));
> +void lbug_with_loc(struct libcfs_debug_msg_data *);
> 
> #define LBUG()							  \
> do {								    \
> -- 
> 2.5.0
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/