linux-kernel - Re: [PATCH] mtd: spi-nor: Add support for sst25wf020a.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201508151529.35983.marex@denx.de>
Date:	Sat, 15 Aug 2015 15:29:35 +0200
From:	Marek Vasut <marex@...x.de>
To:	Alexis Ballier <aballier@...too.org>
Cc:	Ben Hutchings <ben@...adent.org.uk>,
	Rafał Miłecki <zajec5@...il.com>,
	open list <linux-kernel@...r.kernel.org>,
	Gabor Juhos <juhosg@...nwrt.org>,
	"open list:MEMORY TECHNOLOGY DEVICES \(MTD\)" 
	<linux-mtd@...ts.infradead.org>,
	Huang Shijie <shijie.huang@...el.com>,
	Brian Norris <computersforpeace@...il.com>,
	David Woodhouse <dwmw2@...radead.org>,
	"Bean Huo 霍斌斌 \(beanhuo\)" 
	<beanhuo@...ron.com>
Subject: Re: [PATCH] mtd: spi-nor: Add support for sst25wf020a.

On Saturday, August 15, 2015 at 10:38:59 AM, Alexis Ballier wrote:
> On Fri, 14 Aug 2015 22:45:14 +0200
> 
> Marek Vasut <marex@...x.de> wrote:
> > On Friday, August 14, 2015 at 07:35:39 PM, Alexis Ballier wrote:
> > > It is a 256KiB flash with 4 KiB erase sectors
> > > and 64KiB overlay blocks.
> > > 
> > > This is the one available on Hardkernel's Odroid U3 shield.
> > > 
> > > Signed-off-by: Alexis Ballier <aballier@...too.org>
> > > ---
> > > 
> > >  drivers/mtd/spi-nor/spi-nor.c | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/drivers/mtd/spi-nor/spi-nor.c
> > > b/drivers/mtd/spi-nor/spi-nor.c index d78831b..e521b35 100644
> > > --- a/drivers/mtd/spi-nor/spi-nor.c
> > > +++ b/drivers/mtd/spi-nor/spi-nor.c
> > > @@ -636,6 +636,7 @@ static const struct spi_device_id spi_nor_ids[]
> > > = { { "sst25wf512",  INFO(0xbf2501, 0, 64 * 1024,  1, SECT_4K |
> > > SST_WRITE)
> > 
> > },
> > 
> > >  	{ "sst25wf010",  INFO(0xbf2502, 0, 64 * 1024,  2, SECT_4K
> > >  	
> > > | SST_WRITE)
> > 
> > },
> > 
> > >  	{ "sst25wf020",  INFO(0xbf2503, 0, 64 * 1024,  4, SECT_4K
> > >  	
> > > | SST_WRITE)
> > 
> > },
> > 
> > > +	{ "sst25wf020a", INFO(0x621612, 0, 64 * 1024,  4,
> > > SECT_4K) },
> > 
> > Is the SST_WRITE not needed on this device ?
> 
> Tried that at first and it didn't work (writes were silently not
> performed).

This is the worst possible behavior.

> I'm no expert here, but I don't see anything about auto address
> increment in the spec:
> http://ww1.microchip.com/downloads/en/DeviceDoc/20005139E.pdf
> and it uses the page program command (0x02).

They probably decided to start rolling out a standard SPI NOR, which is good :)

Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/