linux-kernel - Re: [PATCH] regulator: core: Define regulator_set_voltage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150815140805.GB10748@sirena.org.uk>
Date:	Sat, 15 Aug 2015 07:08:05 -0700
From:	Mark Brown <broonie@...nel.org>
To:	Viresh Kumar <viresh.kumar@...aro.org>
Cc:	linaro-kernel@...ts.linaro.org, sboyd@...eaurora.org, nm@...com,
	Liam Girdwood <lgirdwood@...il.com>,
	"open list:VOLTAGE AND CURRENT REGULATOR FRAMEWORK" 
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] regulator: core: Define regulator_set_voltage_triplet()

On Sat, Aug 15, 2015 at 08:41:49AM +0530, Viresh Kumar wrote:

> Hopefully below version looks better ?

Please don't bury patches at the end of replies to messages in the
middle of threads, send them in a form where they can be applied
directly.

> Subject: [PATCH] regulator: core: Define regulator_set_voltage_triplet()
> 
> The OPP (Operating performance points) v2 bindings allows regulator
> voltage to be supplied as a triplet of <target min max> voltages.
> 
> Add regulator_set_voltage_triplet() API in regulator core to support
> that.

This should explain why this is useful at a regulator API level, not
explain that some user decided to do something.

> +static inline int regulator_set_voltage_triplet(struct regulator *regulator,
> +						int min_uV, int target_uV,
> +						int max_uV)
> +{
> +	if (!regulator_set_voltage(regulator, target_uV, max_uV))

Make this a check for == 0 which is what you mean here, this isn't a
boolean function.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)