linux-kernel - Re: [PATCH V3 0/6] Introduce framework for SLIMbus device drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150814184637.GH10748@sirena.org.uk>
Date:	Fri, 14 Aug 2015 19:46:37 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Sagar Dharia <sdharia@...eaurora.org>
Cc:	gregkh@...uxfoundation.org, bp@...e.de, poeschel@...onage.de,
	treding@...dia.com, gong.chen@...ux.intel.com,
	andreas.noever@...il.com, alan@...ux.intel.com,
	mathieu.poirier@...aro.org, daniel@...ll.ch, oded.gabbay@....com,
	jkosina@...e.cz, sharon.dvir1@...l.huji.ac.il, joe@...ches.com,
	davem@...emloft.net, james.hogan@...tec.com,
	michael.opdenacker@...e-electrons.com, daniel.thompson@...aro.org,
	robh+dt@...nel.org, pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	kheitke@...ience.com, mlocke@...eaurora.org, agross@...eaurora.org,
	linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH V3 0/6] Introduce framework for SLIMbus device drivers

On Mon, Aug 03, 2015 at 12:59:44AM -0600, Sagar Dharia wrote:

> Sagar Dharia (6):
>   SLIMbus: Device management on SLIMbus
>   of/slimbus: OF helper for SLIMbus
>   slimbus: Add messaging APIs to slimbus framework
>   slim: qcom: Add Qualcomm Slimbus controller driver
>   slimbus: Add support for 'clock-pause' feature
>   slim: qcom: Add runtime-pm support using clock-pause feature

This looks pretty good overall but I did have a few fairly specific
comments that I've sent on some bits.  I see there are a number of users
of this API onn the CC list, it'd be really nice to see some more
participation from them on the review here - are you using this code, do
you have testing reports or any more specific comments on the code?

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)