linux-kernel - Re: [PATCH] rhashtable-test: extend to test concurrency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150816181234.GC31357@breakpoint.cc>
Date:	Sun, 16 Aug 2015 20:12:35 +0200
From:	Florian Westphal <fw@...len.de>
To:	Phil Sutter <phil@....cc>
Cc:	Thomas Graf <tgraf@...g.ch>, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH] rhashtable-test: extend to test concurrency

Phil Sutter <phil@....cc> wrote:
> After having tested insertion, lookup, table walk and removal, spawn a
> number of threads running operations on the same rhashtable. Each of
> them will:

[..]

> +	if (down_interruptible(&startup_sem))
> +		pr_err("  thread[%d]: down_interruptible failed\n", tdata->id);

Why _interruptible?

Seems this should use down() instead.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/