linux-kernel - Re: [RFT PATCH] arm: omap1_defconfig: convert to use libata PATA drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 16 Aug 2015 23:34:55 -0700
From:	Tony Lindgren <tony@...mide.com>
To:	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Cc:	linux-arm-kernel@...ts.infradead.org, linux-ide@...r.kernel.org,
	linux-kernel@...r.kernel.org, Arnd Bergmann <arnd@...db.de>,
	Olof Johansson <olof@...om.net>,
	Russell King <linux@....linux.org.uk>,
	linux-omap@...r.kernel.org
Subject: Re: [RFT PATCH] arm: omap1_defconfig: convert to use libata PATA
 drivers

* Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com> [150814 10:10]:
> IDE subsystem has been deprecated since 2009 and the majority
> (if not all) of Linux distributions have switched to use
> libata for ATA support exclusively.  However there are still
> some users (mostly old or/and embedded non-x86 systems) that
> have not converted from using IDE subsystem to libata PATA
> drivers.  This doesn't seem to be good thing in the long-term
> for Linux as while there is less and less PATA systems left
> in use:
> 
> * testing efforts are divided between two subsystems
> 
> * having duplicate drivers for same hardware confuses users
> 
> This patch converts omap1_defconfig to use libata PATA
> drivers.
> 
> Cc: Tony Lindgren <tony@...mide.com>
> Cc: linux-omap@...r.kernel.org
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
> ---
> Build tested only.
> If you have affected hardware please test.  Thank you.

All my omap1 devices are in a rack using NFSroot or MMC so
I can't test this. Seems like a good idea to me thoug, and does
not cause merge conflicts. So if you want to queue this via
along with other PATA related patches, please feel free to
add:

Acked-by: Tony Lindgren <tony@...mide.com>
 
>  arch/arm/configs/omap1_defconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/configs/omap1_defconfig b/arch/arm/configs/omap1_defconfig
> index 0c8a787..6ffc984 100644
> --- a/arch/arm/configs/omap1_defconfig
> +++ b/arch/arm/configs/omap1_defconfig
> @@ -96,14 +96,14 @@ CONFIG_BLK_DEV_LOOP=y
>  CONFIG_BLK_DEV_RAM=y
>  CONFIG_BLK_DEV_RAM_COUNT=2
>  CONFIG_BLK_DEV_RAM_SIZE=8192
> -CONFIG_IDE=m
> -CONFIG_BLK_DEV_IDECS=m
>  CONFIG_SCSI=y
>  # CONFIG_SCSI_PROC_FS is not set
>  CONFIG_BLK_DEV_SD=y
>  CONFIG_CHR_DEV_ST=y
>  CONFIG_BLK_DEV_SR=y
>  CONFIG_CHR_DEV_SG=y
> +CONFIG_ATA=m
> +CONFIG_PATA_PCMCIA=m
>  CONFIG_NETDEVICES=y
>  CONFIG_TUN=y
>  CONFIG_PHYLIB=y
> -- 
> 1.9.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/