linux-kernel - Re: [PATCH 1/3] platform/chrome: Don't make CHROME

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 17 Aug 2015 09:56:55 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Javier Martinez Canillas <javier.martinez@...labora.co.uk>
Cc:	Lee Jones <lee.jones@...aro.org>,
	"linux-samsung-soc@...r.kernel.org" 
	<linux-samsung-soc@...r.kernel.org>,
	Heiko Stuebner <heiko@...ech.de>,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	Gwendal Grignou <gwendal@...gle.com>,
	Doug Anderson <dianders@...omium.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Olof Johansson <olof@...om.net>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH 1/3] platform/chrome: Don't make CHROME_PLATFORMS depends
 on X86 || ARM

On Thu, Jun 25, 2015 at 2:20 AM, Javier Martinez Canillas
<javier.martinez@...labora.co.uk> wrote:
> The Chrome platform support depends on X86 || ARM because there are
> only Chromebooks using those architectures. But only some drivers
> depend on a given architecture, and the ones that do already have
> a dependency on their specific Kconfig symbol entries.
>
> An option is to also make CHROME_PLATFORMS depends on || COMPILE_TEST
> but is more future proof to remove the dependency and let the drivers
> be built in all architectures if possible to have more build coverage.
>
> Signed-off-by: Javier Martinez Canillas <javier.martinez@...labora.co.uk>

NAKed-by: Geert Uytterhoeven <geert@...ux-m68k.org>

The proper way to have more build coverage is to extend the dependencies
with "|| COMPILE_TEST".

Yes I know MFD_CROS_EC selects CHROME_PLATFORMS, causing a
Kconfig warning on !X86 and !ARM.

Mixing "select" and "depends" (all other ChromeOS stuff depends on the
symbol) is bad practice, as it may lead to circular Kconfig dependencies.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/